From 70073ad004cb3509176d4f63e99c1f8b5f9e75e3 Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Thu, 25 Mar 2021 18:55:45 +0800 Subject: [PATCH] ceph-pr-commits: remove non-ascii char otherwise `jenkins-jobs test` fails when reading it in non-utf-8 locale, Traceback (most recent call last): File "/tmp/venv.KVnqGXyZ3a/bin/jenkins-jobs", line 8, in sys.exit(main()) File "/tmp/venv.KVnqGXyZ3a/lib/python3.6/site-packages/jenkins_jobs/cli/entry.py", line 165, in main jjb.execute() File "/tmp/venv.KVnqGXyZ3a/lib/python3.6/site-packages/jenkins_jobs/cli/entry.py", line 146, in execute ext.obj.execute(self.options, self.jjb_config) File "/tmp/venv.KVnqGXyZ3a/lib/python3.6/site-packages/jenkins_jobs/cli/subcommand/test.py", line 66, in execute config_xml=options.config_xml) File "/tmp/venv.KVnqGXyZ3a/lib/python3.6/site-packages/jenkins_jobs/builder.py", line 279, in update_jobs output.write(job.output()) File "/tmp/venv.KVnqGXyZ3a/lib/python3.6/codecs.py", line 836, in write return self.writer.write(data) File "/tmp/venv.KVnqGXyZ3a/lib/python3.6/codecs.py", line 376, in write data, consumed = self.encode(object, self.errors) UnicodeEncodeError: 'latin-1' codec can't encode character '\u2014' in position 57823: ordinal not in range(256) before this change: $ iconv -f ascii -t ascii < ./ceph-pr-commits/build/build ... input sequence at position 197 after this change, $ iconv -f ascii -t ascii < ./ceph-pr-commits/build/build finishes without issues. Signed-off-by: Kefu Chai --- ceph-pr-commits/build/build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ceph-pr-commits/build/build b/ceph-pr-commits/build/build index 3264fa1d7..4c134b4d4 100644 --- a/ceph-pr-commits/build/build +++ b/ceph-pr-commits/build/build @@ -2,7 +2,7 @@ # Don't require signed commits if only docs changed. # I tried using the excluded-regions parameter for the ghprb plugin but since -# this job/check is required, it hung with 'Expected — Waiting for status to be reported' +# this job/check is required, it hung with 'Expected - Waiting for status to be reported' docs_pr_only if [ "$DOCS_ONLY" = false ]; then echo "Not a docs only change. Will proceed with signed commit check." -- 2.47.3