From d105ce6708e70a17ccb304e2282ce128c158da9d Mon Sep 17 00:00:00 2001 From: Haomai Wang Date: Mon, 23 Oct 2017 13:20:31 +0800 Subject: [PATCH] osd/OpRequest: don't mark_event when disable tracker Signed-off-by: Haomai Wang --- src/common/TrackedOp.h | 3 +++ src/osd/OpRequest.cc | 12 +++++++----- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/src/common/TrackedOp.h b/src/common/TrackedOp.h index d619dc4e7b48..710b3bdacaf3 100644 --- a/src/common/TrackedOp.h +++ b/src/common/TrackedOp.h @@ -86,6 +86,9 @@ public: void set_history_slow_op_size_and_threshold(uint32_t new_size, uint32_t new_threshold) { history.set_slow_op_size_and_threshold(new_size, new_threshold); } + bool is_tracking() const { + return tracking_enabled; + } void set_tracking(bool enable) { tracking_enabled = enable; } diff --git a/src/osd/OpRequest.cc b/src/osd/OpRequest.cc index 0a4b99ee1a4b..235db029d49f 100644 --- a/src/osd/OpRequest.cc +++ b/src/osd/OpRequest.cc @@ -39,11 +39,13 @@ OpRequest::OpRequest(Message *req, OpTracker *tracker) : } else if (req->get_type() == MSG_OSD_REPOPREPLY) { reqid = static_cast(req)->reqid; } - req_src_inst = req->get_source_inst(); - mark_event("header_read", request->get_recv_stamp()); - mark_event("throttled", request->get_throttle_stamp()); - mark_event("all_read", request->get_recv_complete_stamp()); - mark_event("dispatched", request->get_dispatch_stamp()); + if (tracker->is_tracking()) { + req_src_inst = req->get_source_inst(); + mark_event("header_read", request->get_recv_stamp()); + mark_event("throttled", request->get_throttle_stamp()); + mark_event("all_read", request->get_recv_complete_stamp()); + mark_event("dispatched", request->get_dispatch_stamp()); + } } void OpRequest::_dump(Formatter *f) const -- 2.47.3