From 66a9e60237cf2e573c730e20b47f0729544b3748 Mon Sep 17 00:00:00 2001 From: Lucian Petrut Date: Thu, 25 May 2023 07:55:39 +0000 Subject: [PATCH] windows: use bluestore instead of memstore by default We've been using memstore in order to put as much load as possible on the Windows clients in a relatively short timeframe. However, we've been hitting memstore segfaults: https://tracker.ceph.com/issues/61416 For this reason, we'll make the OSD backend configurable, defaulting to bluestore for now. Signed-off-by: Lucian Petrut --- scripts/ceph-windows/setup_ceph_vstart | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/scripts/ceph-windows/setup_ceph_vstart b/scripts/ceph-windows/setup_ceph_vstart index 4f320778..254a7017 100644 --- a/scripts/ceph-windows/setup_ceph_vstart +++ b/scripts/ceph-windows/setup_ceph_vstart @@ -6,7 +6,10 @@ if [[ -z $UBUNTU_SSH_USER ]]; then echo "ERROR: The UBUNTU_SSH_USER env variable if [[ -z $UBUNTU_VM_IP ]]; then echo "ERROR: The UBUNTU_VM_IP env variable is not set"; exit 1; fi export VSTART_DIR="$WORKSPACE/ceph_vstart" -export VSTART_MEMSTORE_BYTES="5368709120" # 5GB + +USE_MEMSTORE="${USE_MEMSTORE:-no}" +VSTART_MEMSTORE_BYTES="5368709120" # 5GB +VSTART_BLUESTORE_BYTES="5368709120" # 5GB export SSH_USER=$UBUNTU_SSH_USER export SSH_ADDRESS=$UBUNTU_VM_IP @@ -43,6 +46,12 @@ time rsync_cmd $WORKSPACE/ceph ${VSTART_DIR}/build-ceph-vstart.sh ${UBUNTU_SSH_U time SSH_TIMEOUT=1h ssh_exec ./build-ceph-vstart.sh ssh_exec sudo apt-get install -y python3-prettytable +if [[ "$USE_MEMSTORE" == "yes" ]]; then + OBJECTSTORE_ARGS="--memstore -o memstore_device_bytes=$VSTART_MEMSTORE_BYTES" +else + OBJECTSTORE_ARGS="--bluestore -o bluestore_block_size=$VSTART_BLUESTORE_BYTES" +fi + # # Run Ceph vstart # @@ -51,7 +60,7 @@ mkdir -p \$HOME/ceph-vstart/out cd ~/ceph/build VSTART_DEST=\$HOME/ceph-vstart ../src/vstart.sh \ - -n --memstore -o "memstore_device_bytes=$VSTART_MEMSTORE_BYTES" \ + -n $OBJECTSTORE_ARGS \ --without-dashboard -i "$UBUNTU_VM_IP" \ 2>&1 | tee \$HOME/ceph-vstart/vstart.log -- 2.47.3