From 62f90da7db26e088095f8c223a23a1c90c158c1f Mon Sep 17 00:00:00 2001
From: John Spray <john.spray@redhat.com>
Date: Thu, 21 Jun 2018 14:13:36 +0100
Subject: [PATCH] mgr: remove unused [get|set]_store_json fns

These were little used helpers, now totally unused!

Signed-off-by: John Spray <john.spray@redhat.com>
---
 doc/mgr/plugins.rst               |  2 --
 src/pybind/mgr/mgr_module.py      | 22 ----------------------
 src/pybind/mgr/selftest/module.py |  5 +----
 3 files changed, 1 insertion(+), 28 deletions(-)

diff --git a/doc/mgr/plugins.rst b/doc/mgr/plugins.rst
index 8cfab3520fca1..8e67819e010d6 100644
--- a/doc/mgr/plugins.rst
+++ b/doc/mgr/plugins.rst
@@ -157,8 +157,6 @@ a particular prefix (i.e. all keys starting with a particular substring).
 
 .. automethod:: MgrModule.get_store
 .. automethod:: MgrModule.set_store
-.. automethod:: MgrModule.set_store_json
-.. automethod:: MgrModule.get_store_json
 .. automethod:: MgrModule.get_localized_store
 .. automethod:: MgrModule.set_localized_store
 .. automethod:: MgrModule.get_store_prefix
diff --git a/src/pybind/mgr/mgr_module.py b/src/pybind/mgr/mgr_module.py
index 1db2e71a425e3..5856836ae560e 100644
--- a/src/pybind/mgr/mgr_module.py
+++ b/src/pybind/mgr/mgr_module.py
@@ -622,28 +622,6 @@ class MgrModule(ceph_module.BaseMgrModule):
         self._validate_option(key)
         return self._set_localized(key, val, self._set_config)
 
-    def set_store_json(self, key, val):
-        """
-        Helper for setting json-serialized stored data
-
-        :param str key:
-        :param val: json-serializable object
-        """
-        self.set_store(key, json.dumps(val))
-
-    def get_store_json(self, key):
-        """
-        Helper for getting json-serialized stored data
-
-        :param str key:
-        :return: object
-        """
-        raw = self.get_store(key)
-        if raw is None:
-            return None
-        else:
-            return json.loads(raw)
-
     def set_store(self, key, val):
         """
         Set a value in this module's persistent key value store
diff --git a/src/pybind/mgr/selftest/module.py b/src/pybind/mgr/selftest/module.py
index dfc57ae5c2bfd..4b5d703d7262f 100644
--- a/src/pybind/mgr/selftest/module.py
+++ b/src/pybind/mgr/selftest/module.py
@@ -163,11 +163,8 @@ class Module(MgrModule):
         self.set_store("testkey", "testvalue")
         assert self.get_store("testkey") == "testvalue"
 
-        self.set_store_json("testjsonkey", {"testblob": 2})
-        assert self.get_store_json("testjsonkey") == {"testblob": 2}
-
         assert sorted(self.get_store_prefix("test").keys()) == sorted(
-                list({"testkey", "testjsonkey"} | existing_keys))
+                list({"testkey"} | existing_keys))
 
 
     def _self_test_perf_counters(self):
-- 
2.39.5