From 9a7d1f5197cd1e7e9225d24dc2682f1de475a29c Mon Sep 17 00:00:00 2001 From: Joao Eduardo Luis Date: Fri, 19 Apr 2013 20:20:12 +0100 Subject: [PATCH] mon: Monitor: fix timechecks get_health clobbering overall status Signed-off-by: Joao Eduardo Luis --- src/mon/Monitor.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mon/Monitor.cc b/src/mon/Monitor.cc index c13773be817e..cc8527ed7f7e 100644 --- a/src/mon/Monitor.cc +++ b/src/mon/Monitor.cc @@ -2259,7 +2259,8 @@ void Monitor::get_health(string& status, bufferlist *detailbl, Formatter *f) ostringstream tcss; health_status_t tcstatus = timecheck_status(tcss, skew, latency); if (tcstatus != HEALTH_OK) { - overall = tcstatus; + if (overall > tcstatus) + overall = tcstatus; warns.push_back(name); ostringstream tmp_ss; -- 2.47.3