From ee02293ad2ef050672fa8c164ba17b10e8d4ceeb Mon Sep 17 00:00:00 2001 From: Loic Dachary Date: Tue, 26 Aug 2014 21:59:39 +0200 Subject: [PATCH] tests: histogram prevent re-use of local variables By moving the test to a separate function. http://tracker.ceph.com/issues/9235 Fixes: #9235 Signed-off-by: Loic Dachary --- src/test/common/histogram.cc | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/src/test/common/histogram.cc b/src/test/common/histogram.cc index 2fd3cfec2a7a..2b54e6375133 100644 --- a/src/test/common/histogram.cc +++ b/src/test/common/histogram.cc @@ -93,15 +93,17 @@ TEST(Histogram, Position) { ASSERT_EQ(500000u, lb); ASSERT_EQ(500000u, ub); } - { - pow2_hist_t h; - h.h.resize(10, 0); - h.h[0] = UINT_MAX; - h.h[5] = UINT_MAX; - uint64_t lb, ub; - ASSERT_EQ(500000u, lb); - ASSERT_EQ(500000u, ub); - } +} + +TEST(Histogram, Position2) { + pow2_hist_t h; + h.h.resize(10, 0); + h.h[0] = UINT_MAX; + h.h[5] = UINT_MAX; + uint64_t lb, ub; + h.get_position_micro(4, &lb, &ub); + ASSERT_EQ(500000u, lb); + ASSERT_EQ(500000u, ub); } TEST(Histogram, Decay) { -- 2.47.3