From 22a0483d1cd0528047b34d24a5d7f14893d876b2 Mon Sep 17 00:00:00 2001 From: Zack Cerza Date: Wed, 11 Sep 2019 09:54:36 -0600 Subject: [PATCH] Revert comparison "fix" from ansible-lint In d737083, we thought we were fixing something, but it turns out the comparison suggested will throw an error if container_name contains a dash (which it likely will). Revert the change and instruct ansible-lint to not complain about that error on that line. Resolves: rhbz#1731919 Signed-off-by: Zack Cerza --- ansible/roles/ceph-mgr/tasks/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ansible/roles/ceph-mgr/tasks/main.yml b/ansible/roles/ceph-mgr/tasks/main.yml index d0c0f04..80a709c 100644 --- a/ansible/roles/ceph-mgr/tasks/main.yml +++ b/ansible/roles/ceph-mgr/tasks/main.yml @@ -26,7 +26,7 @@ - name: Prefix the mgr command with a docker command set_fact: mgr_prefix: "docker exec {{ container_name }}" - when: container_name + when: container_name != "" # noqa 602 - name: Enable mgr prometheus module command: "{{ mgr_prefix|default('') }} ceph --cluster {{ cluster_name }} mgr module enable prometheus" -- 2.47.3