From 4c86b6c34e1c88f67acb72fefb36b89a19264f15 Mon Sep 17 00:00:00 2001
From: Jianpeng Ma <jianpeng.ma@intel.com>
Date: Thu, 22 Nov 2018 15:36:40 +0800
Subject: [PATCH] test_shared_cache: fix memory leak.

Based on SharedLRU::add,  If the key already existed, you are
responsible for deleting the new value you tried to insert.

Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
---
 src/test/common/test_shared_cache.cc | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/test/common/test_shared_cache.cc b/src/test/common/test_shared_cache.cc
index 8db5d9ce37c..eeb526236c9 100644
--- a/src/test/common/test_shared_cache.cc
+++ b/src/test/common/test_shared_cache.cc
@@ -109,9 +109,11 @@ TEST_F(SharedLRU_all, add) {
   }
   {
     int value2 = 3;
-    std::shared_ptr<int> ptr = cache.add(key, new int(value2), &existed);
+    auto p = new int(value2);
+    std::shared_ptr<int> ptr = cache.add(key, p, &existed);
     ASSERT_EQ(value1, *ptr);
     ASSERT_TRUE(existed);
+    delete p;
   }
 }
 TEST_F(SharedLRU_all, empty) {
-- 
2.47.3