From 3c333f3599642f29dc7a080570ed6b1954e49dce Mon Sep 17 00:00:00 2001 From: Xinying Song Date: Tue, 15 Jan 2019 19:18:20 +0800 Subject: [PATCH] mgr: Apply sanity check for daemon metadata Signed-off-by: Xinying Song --- src/mgr/Mgr.cc | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/mgr/Mgr.cc b/src/mgr/Mgr.cc index e4c83c4e1526..24188518bfa3 100644 --- a/src/mgr/Mgr.cc +++ b/src/mgr/Mgr.cc @@ -85,6 +85,13 @@ void MetadataUpdate::finish(int r) json_spirit::mObject daemon_meta = json_result.get_obj(); + // Skip daemon who doesn't have hostname yet + if (daemon_meta.count("hostname") == 0) { + dout(1) << "Skipping incomplete metadata entry for " + << key.first << "." << key.second << dendl; + return; + } + // Apply any defaults for (const auto &i : defaults) { if (daemon_meta.find(i.first) == daemon_meta.end()) { -- 2.47.3