From 078981ca4ef1610ab89b60f4c281f521d6838a37 Mon Sep 17 00:00:00 2001 From: Matt Benjamin Date: Wed, 30 Jan 2019 14:09:47 -0500 Subject: [PATCH] rgw: check for non-existent bucket in RGWGetACLs Fix incorrect result when attempting to fetch an ACL for a bucket that does not exist. This change leads to a NoSuchBucket error result when an ACL is requested from a non-existent bucket. A NoSuchKey error result iss already seen when the target was an object. Fixes: https://tracker.ceph.com/issues/38116 Signed-off-by: Matt Benjamin --- src/rgw/rgw_op.cc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/rgw/rgw_op.cc b/src/rgw/rgw_op.cc index 3b12fffa8b6b..1d0f9a83caa4 100644 --- a/src/rgw/rgw_op.cc +++ b/src/rgw/rgw_op.cc @@ -4903,6 +4903,9 @@ int RGWGetACLs::verify_permission() } perm = verify_object_permission(this, s, iam_action); } else { + if (!s->bucket_exists) { + return -ERR_NO_SUCH_BUCKET; + } perm = verify_bucket_permission(this, s, rgw::IAM::s3GetBucketAcl); } if (!perm) -- 2.47.3