From 996b4f41fae6c05b3085b68f19a4f28dd2adfc6c Mon Sep 17 00:00:00 2001 From: Ilya Dryomov Date: Wed, 6 Mar 2019 15:43:12 +0100 Subject: [PATCH] test/librbd: create shouldn't be called in DiscardTruncate{AssertExists,} MockTestMemIoCtxImpl is a NiceMock which suppresses all "uninteresting method call" warnings. Add explicit Times(0) expectations. Signed-off-by: Ilya Dryomov --- src/test/librbd/io/test_mock_ObjectRequest.cc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/test/librbd/io/test_mock_ObjectRequest.cc b/src/test/librbd/io/test_mock_ObjectRequest.cc index 2f9368af7a744..98cd102629bd2 100644 --- a/src/test/librbd/io/test_mock_ObjectRequest.cc +++ b/src/test/librbd/io/test_mock_ObjectRequest.cc @@ -942,6 +942,8 @@ TEST_F(TestMockIoObjectRequest, DiscardTruncateAssertExists) { expect_assert_exists(mock_image_ctx, 0); expect_truncate(mock_image_ctx, 0, 0); + EXPECT_CALL(get_mock_io_ctx(mock_image_ctx.data_ctx), create(_, _)).Times(0); + C_SaferCond ctx; auto req = MockObjectDiscardRequest::create_discard( &mock_image_ctx, ictx->get_object_name(0), 0, 0, @@ -975,6 +977,8 @@ TEST_F(TestMockIoObjectRequest, DiscardTruncate) { expect_object_map_update(mock_image_ctx, 0, 1, OBJECT_EXISTS, {}, false, 0); expect_truncate(mock_image_ctx, 1, 0); + EXPECT_CALL(get_mock_io_ctx(mock_image_ctx.data_ctx), create(_, _)).Times(0); + C_SaferCond ctx; auto req = MockObjectDiscardRequest::create_discard( &mock_image_ctx, ictx->get_object_name(0), 0, 1, -- 2.39.5