From bb9add6cdc583a1307fe8b1f7ad0ec6793232f7d Mon Sep 17 00:00:00 2001 From: Jianpeng Ma Date: Fri, 17 Oct 2014 14:04:40 +0800 Subject: [PATCH] test: fix compile warning in bufferlist.cc MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit test/bufferlist.cc: In member function ‘virtual void Buffer_constructors_Test::TestBody()’: test/bufferlist.cc:154:36: warning: ignoring return value of ‘int system(const char*)’, declared with attribute warn_unused_result [-Wunused-result] ::system("echo ABC > testfile"); ^ test/bufferlist.cc: In member function ‘virtual void TestRawPipe::SetUp()’: test/bufferlist.cc:182:36: warning: ignoring return value of ‘int system(const char*)’, declared with attribute warn_unused_result [-Wunused-result] ::system("echo ABC > testfile"); ^ test/bufferlist.cc: In member function ‘virtual void BufferList_read_file_Test::TestBody()’: test/bufferlist.cc:1768:53: warning: ignoring return value of ‘int system(const char*)’, declared with attribute warn_unused_result [-Wunused-result] ::system("echo ABC > testfile ; chmod 0 testfile"); ^ test/bufferlist.cc:1770:32: warning: ignoring return value of ‘int system(const char*)’, declared with attribute warn_unused_result [-Wunused-result] ::system("chmod +r testfile"); ^ test/bufferlist.cc: In member function ‘virtual void BufferList_read_fd_Test::TestBody()’: test/bufferlist.cc:1781:34: warning: ignoring return value of ‘int system(const char*)’, declared with attribute warn_unused_result [-Wunused-result] ::system("echo ABC > testfile"); Signed-off-by: Jianpeng Ma --- src/test/bufferlist.cc | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/test/bufferlist.cc b/src/test/bufferlist.cc index 3b379afded58b..61ddc0547f31d 100644 --- a/src/test/bufferlist.cc +++ b/src/test/bufferlist.cc @@ -151,7 +151,7 @@ TEST(Buffer, constructors) { unsigned zc_len = 4; ::unlink("testfile"); - ::system("echo ABC > testfile"); + EXPECT_EQ(0, ::system("echo ABC > testfile")); int fd = ::open("testfile", O_RDONLY); bufferptr ptr(buffer::create_zero_copy(zc_len, fd, NULL)); EXPECT_EQ(zc_len, ptr.length()); @@ -179,7 +179,7 @@ protected: virtual void SetUp() { len = 4; ::unlink("testfile"); - ::system("echo ABC > testfile"); + EXPECT_EQ(0, ::system("echo ABC > testfile")); fd = ::open("testfile", O_RDONLY); assert(fd >= 0); } @@ -1765,9 +1765,9 @@ TEST(BufferList, read_file) { bufferlist bl; ::unlink("testfile"); EXPECT_EQ(-ENOENT, bl.read_file("UNLIKELY", &error)); - ::system("echo ABC > testfile ; chmod 0 testfile"); + EXPECT_EQ(0, ::system("echo ABC > testfile ; chmod 0 testfile")); EXPECT_EQ(-EACCES, bl.read_file("testfile", &error)); - ::system("chmod +r testfile"); + EXPECT_EQ(0, ::system("chmod +r testfile")); EXPECT_EQ(0, bl.read_file("testfile", &error)); ::unlink("testfile"); EXPECT_EQ((unsigned)4, bl.length()); @@ -1778,7 +1778,7 @@ TEST(BufferList, read_file) { TEST(BufferList, read_fd) { unsigned len = 4; ::unlink("testfile"); - ::system("echo ABC > testfile"); + EXPECT_EQ(0, ::system("echo ABC > testfile")); int fd = -1; bufferlist bl; EXPECT_EQ(-EBADF, bl.read_fd(fd, len)); -- 2.39.5