From 7b78bad91605da4d7c9f009803323f7fbc930497 Mon Sep 17 00:00:00 2001 From: Nathan Cutler Date: Wed, 17 Apr 2019 14:46:06 +0200 Subject: [PATCH] mon/OSDMonitor: further improve prepare_command_pool_set E2BIG error message d2c0fe9b5319a4404965c40ec92e291802ef30f6 improved this error message, but it can be improved further by suggesting that the pg_num be increased in smaller increments. This commit is not cherry-picked from master because 4d3407ba93b2c15dd86aa7f97bd9f29c3508c60e (merged for Nautilus) removed the error message in question. Fixes: http://tracker.ceph.com/issues/39353 Signed-off-by: Nathan Cutler --- src/mon/OSDMonitor.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mon/OSDMonitor.cc b/src/mon/OSDMonitor.cc index 9d482adeec6f..da9c7d992464 100644 --- a/src/mon/OSDMonitor.cc +++ b/src/mon/OSDMonitor.cc @@ -6798,9 +6798,9 @@ int OSDMonitor::prepare_command_pool_set(const cmdmap_t& cmdmap, int64_t new_pgs = n - p.get_pg_num(); if (new_pgs > g_conf->mon_osd_max_split_count * expected_osds) { ss << "specified pg_num " << n << " is too large (creating " - << new_pgs << " new PGs on ~" << expected_osds - << " OSDs exceeds per-OSD max with mon_osd_max_split_count of " - << g_conf->mon_osd_max_split_count << ')'; + << new_pgs << " new PGs on ~" << expected_osds + << " OSDs would exceed the per-OSD max of " << g_conf->mon_osd_max_split_count + << " given by mon_osd_max_split_count); please increase the pg_num in smaller steps"; return -E2BIG; } p.set_pg_num(n); -- 2.47.3