From 274df2384e2e8951f643256f1f1e0806dcd0611c Mon Sep 17 00:00:00 2001 From: xie xingguo Date: Wed, 10 Apr 2019 11:25:02 +0800 Subject: [PATCH] mgr/ActivePyModules: handle_command - fix broken lock by unlocking properly when module is not available. Fixes: http://tracker.ceph.com/issues/39235 Signed-off-by: xie xingguo (cherry picked from commit 377de7af5fec521642cc781ac67d555d98ea5e03) --- src/mgr/ActivePyModules.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mgr/ActivePyModules.cc b/src/mgr/ActivePyModules.cc index 9e32dce58cac..b5d7ee15ef71 100644 --- a/src/mgr/ActivePyModules.cc +++ b/src/mgr/ActivePyModules.cc @@ -912,6 +912,7 @@ int ActivePyModules::handle_command( auto mod_iter = modules.find(module_name); if (mod_iter == modules.end()) { *ss << "Module '" << module_name << "' is not available"; + lock.Unlock(); return -ENOENT; } -- 2.47.3