From 0cd7eea02fc89b0fe6db035febb14863406a0ece Mon Sep 17 00:00:00 2001 From: Casey Bodley Date: Tue, 4 Jun 2019 16:40:36 -0400 Subject: [PATCH] cls/rgw: test before accessing pkeys->rbegin() if pkeys is empty here, dereferencing rbegin() will crash Fixes: http://tracker.ceph.com/issues/39984 Signed-off-by: Casey Bodley (cherry picked from commit a936a06a657ce1cc118d75f66773aeda4167bbf3) --- src/cls/rgw/cls_rgw.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cls/rgw/cls_rgw.cc b/src/cls/rgw/cls_rgw.cc index 6b21ad1d6afa..2091914ea6ed 100644 --- a/src/cls/rgw/cls_rgw.cc +++ b/src/cls/rgw/cls_rgw.cc @@ -176,7 +176,7 @@ static int get_obj_vals(cls_method_context_t hctx, const string& start, const st if (num_entries == (int)pkeys->size() || !(*pmore)) return 0; - if (pkeys->rbegin()->first > new_start) { + if (pkeys->size() && new_start < pkeys->rbegin()->first) { new_start = pkeys->rbegin()->first; } -- 2.47.3