From 44860213a4d96a8128f7c8acaac85ff6733f81a7 Mon Sep 17 00:00:00 2001 From: Alfredo Deza Date: Tue, 12 Jan 2016 07:45:23 -0500 Subject: [PATCH] be more verbose when a commit fails Signed-off-by: Alfredo Deza --- ceph-pr-commits/build/test_commits.py | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/ceph-pr-commits/build/test_commits.py b/ceph-pr-commits/build/test_commits.py index 2ce809c9..6292bbf1 100644 --- a/ceph-pr-commits/build/test_commits.py +++ b/ceph-pr-commits/build/test_commits.py @@ -14,6 +14,7 @@ ceph_checkout = os.path.join(workspace, 'ceph') def run(command): + print "Running command: %s" % ' '.join(command) process = Popen( command, cwd=ceph_checkout, @@ -45,7 +46,14 @@ class TestSignedOffByCommits(object): def test_signed_off_by(self): for commit in get_commits(): - assert 'Signed-off-by:' in commit + if 'Signed-off-by:' not in commit: + msg = ( + "\nFollowing commit is not signed, please make sure all commits", + "\nare signed following the 'Submitting Patches' guide:", + "\nhttps://github.com/ceph/ceph/blob/master/SubmittingPatches#L61", + "\n", + commit) + raise AssertionError, ' '.join(msg) def extract_sha(self, lines): # XXX Unused for now, if py.test can spit out the hashes in verbose -- 2.47.3