From d1c89845c8f175ab7cf14d45377628178b93b652 Mon Sep 17 00:00:00 2001 From: Nathan Cutler Date: Thu, 5 Sep 2019 16:14:28 +0200 Subject: [PATCH] script/backport-resolve-issue: better error message When a point release is published, sometimes the new target version is not yet in Redmine. Issue a better error message in this case. Signed-off-by: Nathan Cutler --- src/script/backport-resolve-issue | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/script/backport-resolve-issue b/src/script/backport-resolve-issue index 86ce07f180f7..9fed53f10f59 100755 --- a/src/script/backport-resolve-issue +++ b/src/script/backport-resolve-issue @@ -404,9 +404,10 @@ Ceph version: base {}, target {}'''.format(self.github_url, pr_title_trunc, assert ver_to_release()[maybe_stable], \ "SHA1 {} is not based on any known stable release ({})".format(sha1, maybe_stable) tv = "v{}.{}.{}".format(x, y, int(z) + 1) - assert version2version_id[tv], \ - "Target version {} is not in Redmine".format(tv) - self.target_version = tv + if tv in version2version_id: + self.target_version = tv + else: + raise Exception("Version {} not found in Redmine".format(tv)) def mogrify_github_pr_desc(self): if not self.github_pr_desc: -- 2.47.3