From dc7314724024ae1530f551a200ea522faa764004 Mon Sep 17 00:00:00 2001 From: Nathan Cutler Date: Fri, 8 Nov 2019 15:14:10 +0100 Subject: [PATCH] ceph-backport.sh/interactive_setup: abort if Step 3 fails Fixes confusing error message reported by a user: Setup step 3 of 4 - remote repos --------------------------------------------------------------------- Searching "git remote -v" for remote repos ceph-backport.sh: ERROR: Cannot auto-determine fork remote ceph-backport.sh: (Could not find GitHub user callithea's fork of ceph/ceph in "git remote -v") ceph-backport.sh: ERROR: (internal error) fork_remote not set, even after completing Steps 1-3 of interactive setup ceph-backport.sh: This could be reported as a bug! Signed-off-by: Nathan Cutler --- src/script/ceph-backport.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/src/script/ceph-backport.sh b/src/script/ceph-backport.sh index 3c6a6b6cb834..d70b799679a9 100755 --- a/src/script/ceph-backport.sh +++ b/src/script/ceph-backport.sh @@ -627,6 +627,7 @@ function interactive_setup_routine { init_upstream_remote init_fork_remote vet_remotes + [ "$setup_ok" ] || abort_due_to_setup_problem [ "$github_token" ] || assert_fail "github_token not set, even after completing Steps 1-3 of interactive setup" [ "$github_user" ] || assert_fail "github_user not set, even after completing Steps 1-3 of interactive setup" [ "$upstream_remote" ] || assert_fail "upstream_remote not set, even after completing Steps 1-3 of interactive setup" -- 2.47.3