From 50d247f5a2442cc9b99a4d49873c08baa2438285 Mon Sep 17 00:00:00 2001 From: Sage Weil Date: Mon, 23 Dec 2019 10:29:52 -0600 Subject: [PATCH] mgr/cephadm: fix =[] default arg to _create_daemon This is a no-no (pass by reference, not value)! Signed-off-by: Sage Weil --- src/pybind/mgr/cephadm/module.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/pybind/mgr/cephadm/module.py b/src/pybind/mgr/cephadm/module.py index 89e04bc2ec6..384fba9e767 100644 --- a/src/pybind/mgr/cephadm/module.py +++ b/src/pybind/mgr/cephadm/module.py @@ -1044,8 +1044,10 @@ class CephadmOrchestrator(MgrModule, orchestrator.Orchestrator): return self._remove_daemon(args) def _create_daemon(self, daemon_type, daemon_id, host, keyring, - extra_args=[], extra_config=None, + extra_args=None, extra_config=None, reconfig=False): + if not extra_args: + extra_args = [] name = '%s.%s' % (daemon_type, daemon_id) # generate config -- 2.47.3