From a41b68ee0bdbdc461b4473f7c4da1abb3c9ce2c6 Mon Sep 17 00:00:00 2001 From: Sebastian Wagner Date: Mon, 6 Jan 2020 14:08:42 +0100 Subject: [PATCH] mgr/rook: Add some more type annotations Signed-off-by: Sebastian Wagner --- src/pybind/mgr/rook/module.py | 5 +++++ src/pybind/mgr/rook/rook_cluster.py | 1 + 2 files changed, 6 insertions(+) diff --git a/src/pybind/mgr/rook/module.py b/src/pybind/mgr/rook/module.py index 38ead7c40d9a5..73f53387b751f 100644 --- a/src/pybind/mgr/rook/module.py +++ b/src/pybind/mgr/rook/module.py @@ -304,14 +304,17 @@ class RookOrchestrator(MgrModule, orchestrator.Orchestrator): ) def add_mds(self, spec): + # type: (orchestrator.StatelessServiceSpec) -> RookCompletion return self._service_add_decorate('MDS', spec, self.rook_cluster.add_filesystem) def add_rgw(self, spec): + # type: (orchestrator.RGWSpec) -> RookCompletion return self._service_add_decorate('RGW', spec, self.rook_cluster.add_objectstore) def add_nfs(self, spec): + # type: (orchestrator.NFSServiceSpec) -> RookCompletion return self._service_add_decorate("NFS", spec, self.rook_cluster.add_nfsgw) @@ -349,6 +352,7 @@ class RookOrchestrator(MgrModule, orchestrator.Orchestrator): ) def update_mds(self, spec): + # type: (orchestrator.StatelessServiceSpec) -> RookCompletion num = spec.count return write_completion( lambda: self.rook_cluster.update_mds_count(spec.name, num), @@ -357,6 +361,7 @@ class RookOrchestrator(MgrModule, orchestrator.Orchestrator): ) def update_nfs(self, spec): + # type: (orchestrator.NFSServiceSpec) -> RookCompletion num = spec.count return write_completion( lambda: self.rook_cluster.update_nfs_count(spec.name, num), diff --git a/src/pybind/mgr/rook/rook_cluster.py b/src/pybind/mgr/rook/rook_cluster.py index 97fd2ddc43058..78475d23b31e2 100644 --- a/src/pybind/mgr/rook/rook_cluster.py +++ b/src/pybind/mgr/rook/rook_cluster.py @@ -336,6 +336,7 @@ class RookCluster(object): raise def add_filesystem(self, spec): + # type: (orchestrator.StatelessServiceSpec) -> None # TODO use spec.placement # TODO warn if spec.extended has entries we don't kow how # to action. -- 2.47.3