From 55f8fee2c9b90f9584de132592c3567aa98a7ea0 Mon Sep 17 00:00:00 2001 From: "Yan, Zheng" Date: Tue, 6 Jan 2015 20:17:28 +0800 Subject: [PATCH] client: fix use-after-free bug in unmount() If there is error, _release_fh() already outputs error message. No need to print extra error message Fixes: #10412 Signed-off-by: Yan, Zheng --- src/client/Client.cc | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/client/Client.cc b/src/client/Client.cc index 599673d9fbea7..9cbd1cf12ad38 100644 --- a/src/client/Client.cc +++ b/src/client/Client.cc @@ -4637,9 +4637,8 @@ void Client::unmount() while (!fd_map.empty()) { Fh *fh = fd_map.begin()->second; fd_map.erase(fd_map.begin()); - int release_err = _release_fh(fh); - ldout(cct, 0) << " destroyed lost open file " << fh << " on " << *fh->inode << "(async_err = " << release_err << ")" << dendl; - + ldout(cct, 0) << " destroyed lost open file " << fh << " on " << *fh->inode << dendl; + _release_fh(fh); } _ll_drop_pins(); -- 2.47.3