From ea086c69e1626334117e2683dea0fc4c1d0f32dd Mon Sep 17 00:00:00 2001 From: Varsha Rao Date: Thu, 16 Apr 2020 20:28:54 +0530 Subject: [PATCH] Filer: Add error handler in _do_purge_range() Signed-off-by: Varsha Rao (cherry picked from commit 39b25efb26963180a7e0403174868f5a9940ff55) --- src/osdc/Filer.cc | 11 +++++++---- src/osdc/Filer.h | 2 +- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/src/osdc/Filer.cc b/src/osdc/Filer.cc index 83370d8c08bd6..086daf712e90c 100644 --- a/src/osdc/Filer.cc +++ b/src/osdc/Filer.cc @@ -302,6 +302,7 @@ struct PurgeRange { int flags; Context *oncommit; int uncommitted; + int err = 0; PurgeRange(inodeno_t i, const file_layout_t& l, const SnapContext& sc, uint64_t fo, uint64_t no, ceph::real_time t, int fl, Context *fin) @@ -330,7 +331,7 @@ int Filer::purge_range(inodeno_t ino, PurgeRange *pr = new PurgeRange(ino, *layout, snapc, first_obj, num_obj, mtime, flags, oncommit); - _do_purge_range(pr, 0); + _do_purge_range(pr, 0, 0); return 0; } @@ -339,20 +340,22 @@ struct C_PurgeRange : public Context { PurgeRange *pr; C_PurgeRange(Filer *f, PurgeRange *p) : filer(f), pr(p) {} void finish(int r) override { - filer->_do_purge_range(pr, 1); + filer->_do_purge_range(pr, 1, r); } }; -void Filer::_do_purge_range(PurgeRange *pr, int fin) +void Filer::_do_purge_range(PurgeRange *pr, int fin, int err) { PurgeRange::unique_lock prl(pr->lock); + if (err && err != -ENOENT) + pr->err = err; pr->uncommitted -= fin; ldout(cct, 10) << "_do_purge_range " << pr->ino << " objects " << pr->first << "~" << pr->num << " uncommitted " << pr->uncommitted << dendl; if (pr->num == 0 && pr->uncommitted == 0) { - pr->oncommit->complete(0); + pr->oncommit->complete(pr->err); prl.unlock(); delete pr; return; diff --git a/src/osdc/Filer.h b/src/osdc/Filer.h index ce26a547188c1..ea9ac17014d17 100644 --- a/src/osdc/Filer.h +++ b/src/osdc/Filer.h @@ -255,7 +255,7 @@ class Filer { uint64_t first_obj, uint64_t num_obj, ceph::real_time mtime, int flags, Context *oncommit); - void _do_purge_range(struct PurgeRange *pr, int fin); + void _do_purge_range(struct PurgeRange *pr, int fin, int err); /* * probe -- 2.39.5