From 513f32aa5f4f2dbed57ed3e5aec59f7927fa7136 Mon Sep 17 00:00:00 2001 From: Sebastian Wagner Date: Sun, 7 Jun 2020 18:24:30 +0200 Subject: [PATCH] mgr/orch: apply: Fix proper error when passed unknown type Signed-off-by: Sebastian Wagner --- src/pybind/mgr/orchestrator/module.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/pybind/mgr/orchestrator/module.py b/src/pybind/mgr/orchestrator/module.py index 0518941c6e0f9..ec15f2ad78643 100644 --- a/src/pybind/mgr/orchestrator/module.py +++ b/src/pybind/mgr/orchestrator/module.py @@ -1000,7 +1000,9 @@ Usage: else: placmentspec = PlacementSpec.from_string(placement) - assert service_type + if not service_type: + raise OrchestratorValidationError(f'Error: Empty service_type\n{usage}') + specs = [ServiceSpec(service_type, placement=placmentspec, unmanaged=unmanaged)] completion = self.apply(specs) -- 2.47.3