From 67874aeb0cddd45c43e6725d49762e2bb631d08f Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Tue, 4 Aug 2020 15:28:00 +0800 Subject: [PATCH] crimson/admin: do not validate params of ConfigSetHook validate_cmd() should have taken care of this Signed-off-by: Kefu Chai --- src/crimson/admin/admin_socket.cc | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/crimson/admin/admin_socket.cc b/src/crimson/admin/admin_socket.cc index 5c3da6fa5d17..6d0011489df0 100644 --- a/src/crimson/admin/admin_socket.cc +++ b/src/crimson/admin/admin_socket.cc @@ -488,11 +488,8 @@ public: { std::string var; std::vector new_val; - if (!cmd_getval(cmdmap, "var", var) || - !cmd_getval(cmdmap, "val", new_val)) { - return seastar::make_ready_future( - tell_result_t{-EINVAL, "syntax error: 'config set '"}); - } + cmd_getval(cmdmap, "var", var); + cmd_getval(cmdmap, "val", new_val); // val may be multiple words const std::string joined_values = boost::algorithm::join(new_val, " "); return local_conf().set_val(var, joined_values).then([format] { -- 2.47.3