From e7dc69231228ecc61a037e1c4ae7947f5d9bc444 Mon Sep 17 00:00:00 2001 From: Tiago Melo Date: Mon, 22 Jun 2020 14:59:23 +0000 Subject: [PATCH] mgr/dashboard: Fix spell errors Fixes: https://tracker.ceph.com/issues/46917 Signed-off-by: Tiago Melo --- src/pybind/mgr/dashboard/HACKING.rst | 8 ++++---- src/pybind/mgr/dashboard/frontend/cd.js | 2 +- .../rbd-configuration-form.component.html | 2 +- .../ceph/cephfs/cephfs-tabs/cephfs-tabs.component.spec.ts | 2 +- .../src/app/ceph/cluster/logs/logs.component.html | 2 +- .../src/app/ceph/cluster/logs/logs.component.spec.ts | 8 ++++---- .../frontend/src/app/ceph/cluster/logs/logs.component.ts | 6 +++--- .../src/app/ceph/nfs/nfs-form/nfs-form.component.html | 2 +- .../src/app/ceph/nfs/nfs-form/nfs-form.component.ts | 4 ++-- .../rgw-user-swift-key-modal.component.html | 4 ++-- .../login-password-form/login-password-form.component.ts | 2 +- .../core/navigation/breadcrumbs/breadcrumbs.component.ts | 2 +- .../dashboard/frontend/src/styles/bootstrap-extends.scss | 2 +- 13 files changed, 23 insertions(+), 23 deletions(-) diff --git a/src/pybind/mgr/dashboard/HACKING.rst b/src/pybind/mgr/dashboard/HACKING.rst index 4566d4ea8803..ac0945d0f1ea 100644 --- a/src/pybind/mgr/dashboard/HACKING.rst +++ b/src/pybind/mgr/dashboard/HACKING.rst @@ -262,7 +262,7 @@ Build the Code Documentation ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Run ``npm run doc-build`` to generate code docs in the ``documentation/`` -directory. To make them accesible locally for a web browser, run +directory. To make them accessible locally for a web browser, run ``npm run doc-serve`` and they will become available at ``http://localhost:8444``. With ``npm run compodoc -- `` you may `fully configure it `_. @@ -296,7 +296,7 @@ adjust a custom SCSS class. To get the current version of Bootstrap used inside Ceph please refer to the ``package.json`` and search for: -- ``bootstrap``: For the Boostrap version used. +- ``bootstrap``: For the Bootstrap version used. - ``@ng-bootstrap``: For the version of the Angular bindings which we are using. So for the future please do the following when visiting a component: @@ -608,7 +608,7 @@ created during a test and the pool and its properties should be displayed in the Angular Unit Tests: Unit tests, as the name suggests, are tests for smaller units of the code. -Those tests are designed for testing all kinds of Angulars' components (e.g. services, pipes etc.). +Those tests are designed for testing all kinds of Angular components (e.g. services, pipes etc.). They do not require a connection to the backend, hence those tests are independent of it. The expected data of the backend is mocked in the frontend and by using this data the functionality of the frontend can be tested without having to have real data from the backend. @@ -854,7 +854,7 @@ To do that, check the settings in the i18n config file ``src/pybind/mgr/dashboard/frontend/i18n.config.json``:: and make sure that the organization is *ceph*, the project is *ceph-dashboard* and the resource is the one you want to pull from and push to e.g. *Master:master*. To find a list -of avaiable resources visit ``_. +of available resources visit ``_. After you checked the config go to the directory ``src/pybind/mgr/dashboard/frontend`` and run:: diff --git a/src/pybind/mgr/dashboard/frontend/cd.js b/src/pybind/mgr/dashboard/frontend/cd.js index b6ff6d893391..34d0ce29f2d3 100755 --- a/src/pybind/mgr/dashboard/frontend/cd.js +++ b/src/pybind/mgr/dashboard/frontend/cd.js @@ -38,7 +38,7 @@ if (process.argv.includes('--res')) { function prepareLocales() { try { fs.accessSync(backup, fs.constants.F_OK); - logger(`'${backup}' alread exists, restoring it into '${filename}'}`); + logger(`'${backup}' already exists, restoring it into '${filename}'}`); fs.copyFileSync(backup, filename); } catch (err) { fs.copyFileSync(filename, backup); diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/rbd-configuration-form/rbd-configuration-form.component.html b/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/rbd-configuration-form/rbd-configuration-form.component.html index 4e5deedfafc7..130aa32866c1 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/rbd-configuration-form/rbd-configuration-form.component.html +++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/rbd-configuration-form/rbd-configuration-form.component.html @@ -65,7 +65,7 @@ The mininum value is 0 + *ngIf="form.showError('configuration.' + option.name, cfgFormGroup, 'min')">The minimum value is 0 diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/cephfs/cephfs-tabs/cephfs-tabs.component.spec.ts b/src/pybind/mgr/dashboard/frontend/src/app/ceph/cephfs/cephfs-tabs/cephfs-tabs.component.spec.ts index 92480eb2dbca..b02cc9673b9a 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/cephfs/cephfs-tabs/cephfs-tabs.component.spec.ts +++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/cephfs/cephfs-tabs/cephfs-tabs.component.spec.ts @@ -36,7 +36,7 @@ describe('CephfsTabsComponent', () => { const setReload = (sth?: any) => (component['reloadSubscriber'] = sth); const mockRunOutside = () => { component['subscribeInterval'] = () => { - // It's mocked because the rxjs timer subscription ins't called through the use of 'tick'. + // It's mocked because the rxjs timer subscription isn't called through the use of 'tick'. setReload({ unsubscribed: false, unsubscribe: () => { diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/logs/logs.component.html b/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/logs/logs.component.html index 404cccdca50f..d6e62620bfcd 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/logs/logs.component.html +++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/logs/logs.component.html @@ -57,7 +57,7 @@ class="form-control custom-select" [(ngModel)]="priority" (ngModelChange)="filterLogs()"> - diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/logs/logs.component.spec.ts b/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/logs/logs.component.spec.ts index 2112cd2cf0a2..2f15056f83b3 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/logs/logs.component.spec.ts +++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/logs/logs.component.spec.ts @@ -34,9 +34,9 @@ describe('LogsComponent', () => { expect(component).toBeTruthy(); }); - describe('abstractfilters', () => { - it('after initializaed', () => { - const filters = component.abstractfilters(); + describe('abstractFilters', () => { + it('after initialized', () => { + const filters = component.abstractFilters(); expect(filters.priority).toBe('All'); expect(filters.key).toBe(''); expect(filters.yearMonthDay).toBe(''); @@ -47,7 +47,7 @@ describe('LogsComponent', () => { component.selectedDate = { year: 2019, month: 1, day: 1 }; component.startTime = { hour: 1, minute: 10 }; component.endTime = { hour: 12, minute: 10 }; - const filters = component.abstractfilters(); + const filters = component.abstractFilters(); expect(filters.yearMonthDay).toBe('2019-01-01'); expect(filters.sTime).toBe(70); expect(filters.eTime).toBe(730); diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/logs/logs.component.ts b/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/logs/logs.component.ts index b627fb19d42e..d69c07d33e13 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/logs/logs.component.ts +++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/logs/logs.component.ts @@ -18,7 +18,7 @@ export class LogsComponent implements OnInit, OnDestroy { icons = Icons; interval: number; - prioritys: Array<{ name: string; value: string }> = [ + priorities: Array<{ name: string; value: string }> = [ { name: 'Info', value: '[INF]' }, { name: 'Warning', value: '[WRN]' }, { name: 'Error', value: '[ERR]' }, @@ -58,7 +58,7 @@ export class LogsComponent implements OnInit, OnDestroy { }); } - abstractfilters(): any { + abstractFilters(): any { const priority = this.priority; const key = this.search.toLowerCase().replace(/,/g, ''); @@ -107,7 +107,7 @@ export class LogsComponent implements OnInit, OnDestroy { } filterLogs() { - const filters = this.abstractfilters(); + const filters = this.abstractFilters(); this.clog = this.filterExecutor(this.contentData.clog, filters); this.audit_log = this.filterExecutor(this.contentData.audit_log, filters); } diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/nfs/nfs-form/nfs-form.component.html b/src/pybind/mgr/dashboard/frontend/src/app/ceph/nfs/nfs-form/nfs-form.component.html index a8b978c4f7a8..3f596d400802 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/nfs/nfs-form/nfs-form.component.html +++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/nfs/nfs-form/nfs-form.component.html @@ -199,7 +199,7 @@ - +