From 6dc03460ffa1315e91ea21b1125200d3d5a01253 Mon Sep 17 00:00:00 2001 From: Willem Jan Withagen Date: Tue, 6 Oct 2020 00:47:05 +0200 Subject: [PATCH] mds,osd: fix clang warnings to prevent unneeded copies /home/jenkins/workspace/ceph-master-compile/src/osd/OSDMap.cc:3901:19: warning: loop variable 'pg' of type 'const std::__1::pair' creates a copy from type 'const std::__1::pair' [-Wrange-loop-construct] for (const auto pg : *primary_temp) ^ Signed-off-by: Willem Jan Withagen --- src/mds/SimpleLock.h | 2 +- src/osd/OSDMap.cc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mds/SimpleLock.h b/src/mds/SimpleLock.h index dd436790567..5c625b6af06 100644 --- a/src/mds/SimpleLock.h +++ b/src/mds/SimpleLock.h @@ -291,7 +291,7 @@ public: } void init_gather() { - for (const auto p : parent->get_replicas()) { + for (const auto& p : parent->get_replicas()) { more()->gather_set.insert(p.first); } } diff --git a/src/osd/OSDMap.cc b/src/osd/OSDMap.cc index 196a6ea39b6..7cafea2ad1b 100644 --- a/src/osd/OSDMap.cc +++ b/src/osd/OSDMap.cc @@ -3898,7 +3898,7 @@ void OSDMap::print(ostream& out) const for (const auto& pg : *pg_temp) out << "pg_temp " << pg.first << " " << pg.second << "\n"; - for (const auto pg : *primary_temp) + for (const auto& pg : *primary_temp) out << "primary_temp " << pg.first << " " << pg.second << "\n"; for (const auto &addr : blocklist) -- 2.47.3