From 55216a78ab6432670380b62320bac30e07a2aeec Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Tue, 6 Oct 2020 19:09:18 +0800 Subject: [PATCH] crimson/os: mark class with "final" dtor "final" to silence warning like scheduler.cc:145:30: warning: class with destructor marked 'final' cannot be inherited from [-Wfinal-dtor-non-final-class] ~ClassedOpQueueScheduler() final {}; ^ /home/jenkins-build/build/workspace/ceph-perf-crimson/ceph-pr/src/crimson/osd/scheduler/scheduler.cc:52:7: note: mark 'ClassedOpQueueScheduler' as 'final' to silence this warning class ClassedOpQueueScheduler : public Scheduler { ^ Signed-off-by: Kefu Chai --- src/crimson/osd/scheduler/scheduler.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/crimson/osd/scheduler/scheduler.cc b/src/crimson/osd/scheduler/scheduler.cc index 93ffa40a919a..c85cb388ef36 100644 --- a/src/crimson/osd/scheduler/scheduler.cc +++ b/src/crimson/osd/scheduler/scheduler.cc @@ -49,7 +49,7 @@ std::ostream &operator<<(std::ostream &lhs, const scheduler_class_t &c) * OpQueue based implementations. */ template -class ClassedOpQueueScheduler : public Scheduler { +class ClassedOpQueueScheduler final : public Scheduler { const scheduler_class_t cutoff; T queue; -- 2.47.3