From ae2bb428061bc9b65bffe252f03d99e14aadc09e Mon Sep 17 00:00:00 2001 From: Lucian Petrut Date: Fri, 20 Nov 2020 07:06:39 +0000 Subject: [PATCH] rbd: add "help" command to rbd-wnbd At the moment, "rbd-wnbd" says that "help" is an unsupported command, only "rbd-wnbd -h" works. This isn't very user friendly. Although "rbd-wnbd" isn't supposed to be used directly in most cases, users might want to retrieve device specific arguments that can be passed using "rbd device -o". Signed-off-by: Lucian Petrut --- src/tools/rbd_wnbd/rbd_wnbd.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/tools/rbd_wnbd/rbd_wnbd.cc b/src/tools/rbd_wnbd/rbd_wnbd.cc index 2468a47324d4..fbf7392d1849 100644 --- a/src/tools/rbd_wnbd/rbd_wnbd.cc +++ b/src/tools/rbd_wnbd/rbd_wnbd.cc @@ -590,7 +590,7 @@ Service options: --hard-disconnect Skip attempting a soft disconnect --soft-disconnect-timeout Cummulative soft disconnect timeout in seconds, used when disconnecting existing mappings. A hard - disconnect will be issuedwhen hitting the timeout. + disconnect will be issued when hitting the timeout --service-thread-count The number of workers used when mapping or unmapping images. Default: 8 @@ -1138,6 +1138,8 @@ static int parse_args(std::vector& args, cmd = Service; } else if (strcmp(*args.begin(), "stats") == 0) { cmd = Stats; + } else if (strcmp(*args.begin(), "help") == 0) { + return HELP_INFO; } else { *err_msg << "rbd-wnbd: unknown command: " << *args.begin(); return -EINVAL; -- 2.47.3