From e4e49954403233d0769e51219ca52f0240b668ae Mon Sep 17 00:00:00 2001 From: Willem Jan Withagen Date: Fri, 27 Nov 2020 01:17:05 +0100 Subject: [PATCH] librbd: remove unwanted std::move Clang argues: ``` /home/jenkins/workspace/ceph-master-compile/src/librbd/migration/HttpClient.cc:463:16: warning: moving a temporary object prevents copy elision [-Wpessimizing-move] response = std::move(m_parser->release()); ^ /home/jenkins/workspace/ceph-master-compile/src/librbd/migration/HttpClient.cc:463:16: note: remove std::move call here response = std::move(m_parser->release()); ^~~~~~~~~~ ~ 1 warning generated. ``` Signed-off-by: Willem Jan Withagen --- src/librbd/migration/HttpClient.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/librbd/migration/HttpClient.cc b/src/librbd/migration/HttpClient.cc index fff959cca001..0cc51ddd861b 100644 --- a/src/librbd/migration/HttpClient.cc +++ b/src/librbd/migration/HttpClient.cc @@ -460,7 +460,7 @@ private: if (work->header_only()) { m_parser.emplace(std::move(*m_header_parser)); } - response = std::move(m_parser->release()); + response = m_parser->release(); // basic response code handling in a common location int r = 0; -- 2.47.3