From 889a6b451c46f8423e61b994614c3e079333edaa Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Mon, 4 Jan 2021 23:25:10 +0800 Subject: [PATCH] crimson/os: do not let omap_get_values() return input_output_error BlueStore only returns 0 or -ENOENT. so no need to handle the cases where the return value is neither of them. but Seastore might return EIO, so keep the interface unchanged. Signed-off-by: Kefu Chai --- src/crimson/os/alienstore/alien_store.cc | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/crimson/os/alienstore/alien_store.cc b/src/crimson/os/alienstore/alien_store.cc index 8b9955156b679..cb55532545b47 100644 --- a/src/crimson/os/alienstore/alien_store.cc +++ b/src/crimson/os/alienstore/alien_store.cc @@ -316,10 +316,8 @@ auto AlienStore::omap_get_values(CollectionRef ch, }).then([&values] (int r) -> read_errorator::future { if (r == -ENOENT) { return crimson::ct_error::enoent::make(); - } else if (r < 0){ - logger().error("omap_get_values: {}", r); - return crimson::ct_error::input_output_error::make(); } else { + assert(r == 0); return read_errorator::make_ready_future(std::move(values)); } }); -- 2.39.5