From 0fe7907feaec28f376847cfdc1fe9aac9eac64a1 Mon Sep 17 00:00:00 2001 From: David Galloway Date: Tue, 3 Apr 2018 18:22:08 -0400 Subject: [PATCH] common: Comment bad nvme error-log check Signed-off-by: David Galloway --- roles/common/files/libexec/smart.sh | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/roles/common/files/libexec/smart.sh b/roles/common/files/libexec/smart.sh index 60db5b96..19d8aff1 100755 --- a/roles/common/files/libexec/smart.sh +++ b/roles/common/files/libexec/smart.sh @@ -388,12 +388,16 @@ nvme_smart () rc=2 fi # Check for error log entries - if [ "$num_err_log_entries" != "0" ] - then - messages+=("$nvmedisk indicates there are $num_err_log_entries error log entries") - failed=true - rc=2 - fi +# This doesn't appear to be a useful or reliable method of measuring NVMe health. +# I've done a bunch of research and haven't been able to find much of anything +# about this metric. On top of that, all our new reesi NVMe indicate errors but +# there's nothing in the error-logs so I'm commenting this for now. +# if [ "$num_err_log_entries" != "0" ] +# then +# messages+=("$nvmedisk indicates there are $num_err_log_entries error log entries") +# failed=true +# rc=2 +# fi elif [ "$outputcount" != "4" ] then messages+=("$nvmedisk returned $outputcount of 4 expected attributes") -- 2.47.3