From 53139eca6ebb7480402ceb941155895cda67fd85 Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Fri, 19 Feb 2021 12:04:32 +0800 Subject: [PATCH] cmake: build static libs if they are internal ones there are chances that user or build script set `BUILD_SHARED_LIBS`, so these convenience libraries (using the autotools' terminology) are built and linked by never get installed. Fixes: https://tracker.ceph.com/issues/38611 Fixes: https://tracker.ceph.com/issues/49080 Signed-off-by: Kefu Chai (cherry picked from commit df841b241efd387044d9637b1cf67d198bd1398e) Conflicts: src/blk/CMakeLists.txt introduced in pacific https://github.com/ceph/ceph/pull/34622/files --- src/common/CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/common/CMakeLists.txt b/src/common/CMakeLists.txt index 5e7fb6a78eb..7a880532170 100644 --- a/src/common/CMakeLists.txt +++ b/src/common/CMakeLists.txt @@ -171,7 +171,7 @@ elseif(HAVE_ARMV8_CRC) crc32c_aarch64.c) endif(HAVE_INTEL) -add_library(crc32 ${crc32_srcs}) +add_library(crc32 STATIC ${crc32_srcs}) if(HAVE_ARMV8_CRC) set_target_properties(crc32 PROPERTIES COMPILE_FLAGS "${CMAKE_C_FLAGS} ${ARMV8_CRC_COMPILE_FLAGS}") -- 2.47.3