From bf3ea637c16413b5d4dca19205d0463616e82bd4 Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Wed, 26 May 2021 14:02:51 +0800 Subject: [PATCH] vstart.sh: use || instead of "-o" to silence the warning like: SC2166: Prefer [ p ] || [ q ] as [ p -o q ] is not well defined. see also https://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html Signed-off-by: Kefu Chai --- src/vstart.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/vstart.sh b/src/vstart.sh index 8bd32bd0746..c7797025d68 100755 --- a/src/vstart.sh +++ b/src/vstart.sh @@ -253,9 +253,10 @@ parse_block_devs() { shift local devs=$1 shift + local dev IFS=',' read -r -a block_devs <<< "$devs" for dev in "${block_devs[@]}"; do - if [ ! -b $dev -o ! -w $dev ]; then + if [ ! -b $dev ] || [ ! -w $dev ]; then echo "All $opt_name must refer to writable block devices" exit 1 fi -- 2.47.3