From 6eacbdcac18dbe4500f455ec1489caaba1e84baa Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Mon, 7 Jun 2021 16:00:23 +0800 Subject: [PATCH] cmake: let vstart-base depend on cython_rados if NOT WIN32 to disable this custom target if NOT WIN32 without explanations is difficult to maintain, so add a comment, and limit the scope to just `cython_rados`. Signed-off-by: Kefu Chai --- src/CMakeLists.txt | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index ed69b15fbef4..73b3279505c6 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -891,7 +891,6 @@ configure_file( ${CMAKE_BINARY_DIR}/include/acconfig.h ) -if(NOT WIN32) # Everything you need to spin up a cluster with vstart.sh add_custom_target(vstart-base DEPENDS ceph-osd @@ -900,8 +899,14 @@ add_custom_target(vstart-base DEPENDS ceph-conf monmaptool crushtool - rados + rados) +if(NOT WIN32) + # WIN32 port does not build python bindings + # TODO: introduce an option for enabling python binding + add_dependencies(vstart-base cython_rados) +endif() + if (WITH_MGR) add_dependencies(vstart-base ceph-mgr) endif() @@ -928,7 +933,6 @@ endif() if(WITH_MGR) add_dependencies(vstart ceph-volume-venv-setup) endif() -endif(NOT WIN32) # Everything you need to run CephFS tests add_custom_target(cephfs_testing DEPENDS -- 2.47.3