From aa3f2028c15aff2dbe1af99e2d899bdc373701a2 Mon Sep 17 00:00:00 2001
From: Kefu Chai <kchai@redhat.com>
Date: Tue, 29 Jun 2021 12:01:20 +0800
Subject: [PATCH] crimson/os/alienstore: return attrs retrieved from bluestore
 directly

since ObjectStore returns a map<...,less<>> already, there is not point to
convert the returned map to the type expected by AlienStore.

Signed-off-by: Kefu Chai <kchai@redhat.com>
---
 src/crimson/os/alienstore/alien_store.cc       | 8 +-------
 src/crimson/osd/replicated_recovery_backend.cc | 4 ++--
 src/crimson/osd/replicated_recovery_backend.h  | 4 ++--
 3 files changed, 5 insertions(+), 11 deletions(-)

diff --git a/src/crimson/os/alienstore/alien_store.cc b/src/crimson/os/alienstore/alien_store.cc
index aa9758147df0c..091e438466c5e 100644
--- a/src/crimson/os/alienstore/alien_store.cc
+++ b/src/crimson/os/alienstore/alien_store.cc
@@ -338,13 +338,7 @@ AlienStore::get_attrs(CollectionRef ch,
   return seastar::do_with(attrs_t{}, [=] (auto &aset) {
     return tp->submit(ch->get_cid().hash_to_shard(tp->size()), [=, &aset] {
       auto c = static_cast<AlienCollection*>(ch.get());
-      std::map<std::string, ceph::bufferptr> blueaset;
-      const auto r = store->getattrs(c->collection, oid, blueaset);
-      for (auto& [bluekey, blueval] : blueaset) {
-        ceph::bufferlist bl;
-        bl.push_back(std::move(blueval));
-        aset.emplace(std::move(bluekey), std::move(bl));
-      }
+      const auto r = store->getattrs(c->collection, oid, aset);
       return r;
     }).then([&aset] (int r) -> get_attrs_ertr::future<attrs_t> {
       if (r == -ENOENT) {
diff --git a/src/crimson/osd/replicated_recovery_backend.cc b/src/crimson/osd/replicated_recovery_backend.cc
index 79e39c6fed3ef..927551d076819 100644
--- a/src/crimson/osd/replicated_recovery_backend.cc
+++ b/src/crimson/osd/replicated_recovery_backend.cc
@@ -927,7 +927,7 @@ ReplicatedRecoveryBackend::prep_push_target(
   bool complete,
   bool clear_omap,
   ObjectStore::Transaction* t,
-  const map<string, bufferlist>& attrs,
+  const map<string, bufferlist, less<>>& attrs,
   bufferlist&& omap_header)
 {
   if (!first) {
@@ -1003,7 +1003,7 @@ ReplicatedRecoveryBackend::submit_push_data(
   interval_set<uint64_t>&& intervals_included,
   bufferlist&& data_included,
   bufferlist&& omap_header,
-  const map<string, bufferlist> &attrs,
+  const map<string, bufferlist, less<>> &attrs,
   map<string, bufferlist>&& omap_entries,
   ObjectStore::Transaction *t)
 {
diff --git a/src/crimson/osd/replicated_recovery_backend.h b/src/crimson/osd/replicated_recovery_backend.h
index 55cd0f17861bd..1d9b6042b9b18 100644
--- a/src/crimson/osd/replicated_recovery_backend.h
+++ b/src/crimson/osd/replicated_recovery_backend.h
@@ -82,7 +82,7 @@ protected:
     interval_set<uint64_t>&& intervals_included,
     ceph::bufferlist&& data_included,
     ceph::bufferlist&& omap_header,
-    const std::map<string, bufferlist> &attrs,
+    const std::map<std::string, bufferlist, std::less<>> &attrs,
     std::map<string, bufferlist>&& omap_entries,
     ceph::os::Transaction *t);
   void submit_push_complete(
@@ -161,7 +161,7 @@ private:
     bool complete,
     bool clear_omap,
     ObjectStore::Transaction* t,
-    const map<string, bufferlist> &attrs,
+    const std::map<std::string, bufferlist, std::less<>> &attrs,
     bufferlist&& omap_header);
   using interruptor = crimson::interruptible::interruptor<
     crimson::osd::IOInterruptCondition>;
-- 
2.39.5