From 1428544ec66b498830bc884b4824cd90106053d5 Mon Sep 17 00:00:00 2001 From: locallocal Date: Mon, 6 Dec 2021 10:01:50 +0800 Subject: [PATCH] os/bluestore: don't need separate variable to mark hits when lookup oid. Signed-off-by: locallocal --- src/os/bluestore/BlueStore.cc | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/os/bluestore/BlueStore.cc b/src/os/bluestore/BlueStore.cc index c8242cb072f..b0a4b88c787 100644 --- a/src/os/bluestore/BlueStore.cc +++ b/src/os/bluestore/BlueStore.cc @@ -1916,12 +1916,12 @@ BlueStore::OnodeRef BlueStore::OnodeSpace::lookup(const ghobject_t& oid) { ldout(cache->cct, 30) << __func__ << dendl; OnodeRef o; - bool hit = false; { std::lock_guard l(cache->lock); ceph::unordered_map::iterator p = onode_map.find(oid); if (p == onode_map.end()) { + cache->logger->inc(l_bluestore_onode_misses); ldout(cache->cct, 30) << __func__ << " " << oid << " miss" << dendl; } else { ldout(cache->cct, 30) << __func__ << " " << oid << " hit " << p->second @@ -1934,15 +1934,10 @@ BlueStore::OnodeRef BlueStore::OnodeSpace::lookup(const ghobject_t& oid) o = p->second; ceph_assert(!o->cached || o->pinned); - hit = true; + cache->logger->inc(l_bluestore_onode_hits); } } - if (hit) { - cache->logger->inc(l_bluestore_onode_hits); - } else { - cache->logger->inc(l_bluestore_onode_misses); - } return o; } -- 2.47.3