From 998ec19bd6434cfa80d59fd52dd2072192c10c2b Mon Sep 17 00:00:00 2001 From: Ilya Dryomov Date: Sat, 8 Jan 2022 14:18:32 +0100 Subject: [PATCH] test/librbd: fix group_info.name leaks in TestGroup.add_image Introduced in commit c04e8c3374e0 ("test/librbd: add get_group test"). Signed-off-by: Ilya Dryomov --- src/test/librbd/test_Groups.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/test/librbd/test_Groups.cc b/src/test/librbd/test_Groups.cc index 8be7e2abab3..88b19146f16 100644 --- a/src/test/librbd/test_Groups.cc +++ b/src/test/librbd/test_Groups.cc @@ -99,8 +99,9 @@ TEST_F(TestGroup, add_image) rbd_group_info_t group_info; ASSERT_EQ(0, rbd_get_group(image, &group_info, sizeof(group_info))); - ASSERT_EQ(0,strcmp("", group_info.name)); + ASSERT_EQ(0, strcmp("", group_info.name)); ASSERT_EQ(RBD_GROUP_INVALID_POOL, group_info.pool); + rbd_group_info_cleanup(&group_info, sizeof(group_info)); ASSERT_EQ(0, rbd_group_image_add(ioctx, group_name, ioctx, m_image_name.c_str())); @@ -109,6 +110,7 @@ TEST_F(TestGroup, add_image) ASSERT_EQ(0, rbd_get_group(image, &group_info, sizeof(group_info))); ASSERT_EQ(0, strcmp(group_name, group_info.name)); ASSERT_EQ(rados_ioctx_get_id(ioctx), group_info.pool); + rbd_group_info_cleanup(&group_info, sizeof(group_info)); ASSERT_EQ(0, rbd_get_features(image, &features)); ASSERT_TRUE((features & RBD_FEATURE_OPERATIONS) == -- 2.47.3