From cff3cf1d31342be759cdd848cd074a247b56b238 Mon Sep 17 00:00:00 2001 From: Avan Thakkar Date: Wed, 21 Sep 2022 02:00:31 +0530 Subject: [PATCH] exporter: avoid stoi for empty pid_str Fixes: https://tracker.ceph.com/issues/57619 Signed-off-by: Avan Thakkar --- src/exporter/DaemonMetricCollector.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/exporter/DaemonMetricCollector.cc b/src/exporter/DaemonMetricCollector.cc index 8d5bad0d97b4..a8fef46548e9 100644 --- a/src/exporter/DaemonMetricCollector.cc +++ b/src/exporter/DaemonMetricCollector.cc @@ -129,7 +129,9 @@ void DaemonMetricCollector::dump_asok_metrics() { dout(1) << "pid path is empty; process metrics won't be fetched for: " << daemon_name << dendl; } - daemon_pids.push_back({daemon_name, std::stoi(pid_str)}); + if (!pid_str.empty()) { + daemon_pids.push_back({daemon_name, std::stoi(pid_str)}); + } json_object dump = boost::json::parse(perf_dump_response).as_object(); json_object schema = boost::json::parse(perf_schema_response).as_object(); for (auto &perf : schema) { -- 2.47.3