From 0635ec97ac06f0194ad973c78d9cf9118574dc4b Mon Sep 17 00:00:00 2001 From: Samuel Just Date: Wed, 28 Sep 2022 23:36:46 +0000 Subject: [PATCH] crimson/.../replicated_request,logmissing_request: retain reference to req Otherwise, operator<< and dump_detail would need to accessing req after the call to handle_rep_op. Fixes: https://tracker.ceph.com/issues/57739 Signed-off-by: Samuel Just --- src/crimson/osd/osd_operations/logmissing_request.cc | 2 +- src/crimson/osd/osd_operations/replicated_request.cc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/crimson/osd/osd_operations/logmissing_request.cc b/src/crimson/osd/osd_operations/logmissing_request.cc index 84efcfa9f6a5..0b6df5a37c88 100644 --- a/src/crimson/osd/osd_operations/logmissing_request.cc +++ b/src/crimson/osd/osd_operations/logmissing_request.cc @@ -61,7 +61,7 @@ seastar::future<> LogMissingRequest::with_pg( IRef ref = this; return interruptor::with_interruption([this, pg] { - return pg->do_update_log_missing(std::move(req)); + return pg->do_update_log_missing(req); }, [ref](std::exception_ptr) { return seastar::now(); }, pg); } diff --git a/src/crimson/osd/osd_operations/replicated_request.cc b/src/crimson/osd/osd_operations/replicated_request.cc index d93e4035ed0f..ac197d8ae7ce 100644 --- a/src/crimson/osd/osd_operations/replicated_request.cc +++ b/src/crimson/osd/osd_operations/replicated_request.cc @@ -61,7 +61,7 @@ seastar::future<> RepRequest::with_pg( IRef ref = this; return interruptor::with_interruption([this, pg] { - return pg->handle_rep_op(std::move(req)); + return pg->handle_rep_op(req); }, [ref](std::exception_ptr) { return seastar::now(); }, pg); } -- 2.47.3