From 88fbb12766e2a31a9af366465f012920c8ca5279 Mon Sep 17 00:00:00 2001 From: Prashant D Date: Mon, 26 Sep 2022 22:40:45 -0400 Subject: [PATCH] mon: Fix condition to check for ceph version mismatch MON fails to send MMgrUpdate to the MGR to update DaemonState with correct metadata information due to incorrect conditional check. Send MMgrUpdate to MGR if we observe ceph version mismatch after an election is over. Fixes: https://tracker.ceph.com/issues/57678 Signed-off-by: Prashant D (cherry picked from commit 5dc0d6f7f299cc7af0c243ba67036b075f4b72af) --- src/mon/Monitor.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mon/Monitor.cc b/src/mon/Monitor.cc index ce7ec37d9cf..dd665d599bd 100644 --- a/src/mon/Monitor.cc +++ b/src/mon/Monitor.cc @@ -2988,7 +2988,7 @@ void Monitor::update_pending_metadata() const std::string current_version = mon_metadata[rank]["ceph_version_short"]; const std::string pending_version = metadata["ceph_version_short"]; - if (current_version.compare(0, version_size, pending_version) < 0) { + if (current_version.compare(0, version_size, pending_version) != 0) { mgr_client.update_daemon_metadata("mon", name, metadata); } } -- 2.47.3