From ff39f87701ba5935902f2a6c67d7ad178bddc5e0 Mon Sep 17 00:00:00 2001 From: John Mulligan Date: Thu, 30 Mar 2023 16:49:27 -0400 Subject: [PATCH] python-common: add a dedicated tox env to run mypy IMO it's not a good practice to overload a tox rule with multiple different test tools. It forces the tools to share the same virtualenvs and makes it impossible to run the tools individually. A separate mypy env also better matches the other tox.ini files in the ceph tree. Since the new 'mypy' env is in the default env list it will continue to get run automatically when no specific envs are selected. Signed-off-by: John Mulligan --- src/python-common/tox.ini | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/python-common/tox.ini b/src/python-common/tox.ini index 0699c047652..2737a87e820 100644 --- a/src/python-common/tox.ini +++ b/src/python-common/tox.ini @@ -1,5 +1,5 @@ [tox] -envlist = py3, lint +envlist = py3, mypy, lint skip_missing_interpreters = true [testenv:py3] @@ -11,6 +11,13 @@ commands= pytest {posargs} mypy --config-file=../mypy.ini -p ceph +[testenv:mypy] +deps= + -rrequirements.txt + -c{toxinidir}/../mypy-constrains.txt +commands= + mypy --config-file=../mypy.ini -p ceph + [tool:pytest] norecursedirs = .* _* virtualenv -- 2.47.3