From dd212fd1d367f70c61f65a97599959668b44aa53 Mon Sep 17 00:00:00 2001 From: Nathan Cutler Date: Thu, 25 Jun 2015 18:55:39 +0200 Subject: [PATCH] ceph.spec.in: clarify two important comments First, the terms "common" and "specific" are vague. Second, "common" can easily be confused with the ceph-common subpackage. Fix this by rephrasing to "distro-unconditional dependencies" and "distro-conditional dependencies", respectively. Third, move the "distro-unconditional dependencies" header so it is above the part where these dependencies are actually defined. Signed-off-by: Nathan Cutler --- ceph.spec.in | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ceph.spec.in b/ceph.spec.in index 8a1d987ba2115..638b0b9b34077 100644 --- a/ceph.spec.in +++ b/ceph.spec.in @@ -18,9 +18,6 @@ %global _with_systemd 1 %endif -################################################################################# -# common -################################################################################# Name: ceph Version: @VERSION@ Release: @RPM_RELEASE@%{?dist} @@ -33,6 +30,9 @@ Source0: http://ceph.com/download/%{name}-%{version}.tar.bz2 %if 0%{?fedora} || 0%{?rhel} Patch0: init-ceph.in-fedora.patch %endif +################################################################################# +# dependencies that apply across all distro families +################################################################################# Requires: librbd1 = %{epoch}:%{version}-%{release} Requires: librados2 = %{epoch}:%{version}-%{release} Requires: libcephfs1 = %{epoch}:%{version}-%{release} @@ -98,7 +98,7 @@ BuildRequires: snappy-devel %endif ################################################################################# -# specific +# distro-conditional dependencies ################################################################################# %if 0%{defined suse_version} BuildRequires: net-tools -- 2.47.3