From 8085d26fe9fa6f4f8ec81606879bbfe761e76c3c Mon Sep 17 00:00:00 2001 From: Jianpeng Ma Date: Tue, 14 Jul 2015 22:02:21 +0800 Subject: [PATCH] common: clean up code for OpTracker::check_ops_in_flight. Signed-off-by: Jianpeng Ma --- src/common/TrackedOp.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/common/TrackedOp.cc b/src/common/TrackedOp.cc index a96b9159917..f759894fb04 100644 --- a/src/common/TrackedOp.cc +++ b/src/common/TrackedOp.cc @@ -187,6 +187,8 @@ bool OpTracker::check_ops_in_flight(std::vector &warning_vector) return false; warning_vector.reserve(log_threshold + 1); + //store summary message + warning_vector.push_back(""); int slow = 0; // total slow int warned = 0; // total logged @@ -205,8 +207,6 @@ bool OpTracker::check_ops_in_flight(std::vector &warning_vector) if (((*i)->get_initiated() + (complaint_time * (*i)->warn_interval_multiplier)) < now) { // will warn - if (warning_vector.empty()) - warning_vector.push_back(""); warned++; if (warned > log_threshold) break; @@ -236,7 +236,7 @@ bool OpTracker::check_ops_in_flight(std::vector &warning_vector) warning_vector[0] = ss.str(); } - return warning_vector.size(); + return warned; } void OpTracker::get_age_ms_histogram(pow2_hist_t *h) -- 2.47.3