From 576e8dc3d2e480ad61a70a3fc49f4f8437c161eb Mon Sep 17 00:00:00 2001 From: Kotresh HR Date: Wed, 16 Aug 2023 12:15:36 +0530 Subject: [PATCH] doc: Fix doc for mds cap acquisition throttle The config values picks the definition from the description. Removed the duplicate description in the doc. Signed-off-by: Kotresh HR (cherry picked from commit 65b0e45dd702fdedcf66f64dd6c5b8ae11df430b) --- doc/cephfs/cache-configuration.rst | 6 ------ src/common/options/mds.yaml.in | 12 ++++++------ 2 files changed, 6 insertions(+), 12 deletions(-) diff --git a/doc/cephfs/cache-configuration.rst b/doc/cephfs/cache-configuration.rst index 19cf414331984..3fc757005d1ab 100644 --- a/doc/cephfs/cache-configuration.rst +++ b/doc/cephfs/cache-configuration.rst @@ -154,14 +154,8 @@ readdir. The behavior of the decay counter is the same as for cache trimming or caps recall. Each readdir call increments the counter by the number of files in the result. -The ratio of ``mds_max_caps_per_client`` that client must exceed before readdir -maybe throttled by cap acquisition throttle: - .. confval:: mds_session_max_caps_throttle_ratio -The timeout in seconds after which a client request is retried due to cap -acquisition throttling: - .. confval:: mds_cap_acquisition_throttle_retry_request_timeout If the number of caps acquired by the client per session is greater than the diff --git a/src/common/options/mds.yaml.in b/src/common/options/mds.yaml.in index b54f32787cc21..90c5df4a10105 100644 --- a/src/common/options/mds.yaml.in +++ b/src/common/options/mds.yaml.in @@ -335,10 +335,10 @@ options: type: float level: advanced desc: decay rate for session readdir caps leading to readdir throttle - long_desc: The half-life for the session cap acquisition counter of caps acquired - by readdir. This is used for throttling readdir requests from clients slow to - release caps. - default: 10 + long_desc: The half-life for the session cap acquisition counter of caps + acquired by readdir. This is used for throttling readdir requests from + clients. + default: 30 services: - mds flags: @@ -346,8 +346,8 @@ options: - name: mds_session_cap_acquisition_throttle type: uint level: advanced - desc: throttle point for cap acquisition decay counter - default: 500000 + desc: threshold at which the cap acquisition decay counter throttles + default: 100000 services: - mds - name: mds_session_max_caps_throttle_ratio -- 2.39.5