From 7179ac0037320480f089e1a9e291cdc37282d250 Mon Sep 17 00:00:00 2001 From: Laura Flores <“lflores@ibm.com”> Date: Fri, 8 Sep 2023 17:49:01 +0000 Subject: [PATCH] src/common: add context to tracing::Tracer::init Followup to https://github.com/ceph/ceph/pull/50948. This wasn't originally caught since the centos 8 default build passed, but it did fail the crimson build: https://shaman.ceph.com/builds/ceph/wip-yuri3-testing-2023-08-15-0955/b5259484dbc61e8573f27e692560c6c107b9d4c1/ Fixes: https://tracker.ceph.com/issues/62761 Signed-off-by: Laura Flores --- src/common/tracer.h | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/common/tracer.h b/src/common/tracer.h index decbca55124c..8a19db39021a 100644 --- a/src/common/tracer.h +++ b/src/common/tracer.h @@ -94,14 +94,16 @@ class jspan { namespace tracing { struct Tracer { + void init(CephContext* _cct, std::string_view service_name) {} bool is_enabled() const { return false; } jspan start_trace(std::string_view, bool enabled = true) { return {}; } jspan add_span(std::string_view, const jspan&) { return {}; } jspan add_span(std::string_view span_name, const jspan_context& parent_ctx) { return {}; } - void init(std::string_view service_name) {} }; - inline void encode(const jspan_context& span, bufferlist& bl, uint64_t f=0) {} - inline void decode(jspan_context& span_ctx, ceph::buffer::list::const_iterator& bl) {} + +inline void encode(const jspan_context& span, bufferlist& bl, uint64_t f=0) {} +inline void decode(jspan_context& span_ctx, ceph::buffer::list::const_iterator& bl) {} + } #endif // !HAVE_JAEGER -- 2.47.3