From 7b98073524d393aa6feb64f0e66cdf3fb71748bb Mon Sep 17 00:00:00 2001 From: Ramana Raja Date: Mon, 30 Oct 2023 11:05:27 -0400 Subject: [PATCH] mgr/rbd_support: remove CreateSnapshotRequests __del__() There is no need for CreateSnapshotRequests.__del__() that calls CreateSnapshotRequests.wait_for_pending(). MirrorSnapshotScheduleHandler.shutdown() already calls CreateSnapshotRequests.wait_for_pending(). Signed-off-by: Ramana Raja (cherry picked from commit fed1e87685a698876cf167b3681327e5b0066ee6) --- src/pybind/mgr/rbd_support/mirror_snapshot_schedule.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/pybind/mgr/rbd_support/mirror_snapshot_schedule.py b/src/pybind/mgr/rbd_support/mirror_snapshot_schedule.py index 0ddc2e6e734ca..e5b19f36228d3 100644 --- a/src/pybind/mgr/rbd_support/mirror_snapshot_schedule.py +++ b/src/pybind/mgr/rbd_support/mirror_snapshot_schedule.py @@ -43,9 +43,6 @@ class CreateSnapshotRequests: self.queue: List[ImageSpec] = [] self.ioctxs: Dict[Tuple[str, str], Tuple[rados.Ioctx, Set[ImageSpec]]] = {} - def __del__(self) -> None: - self.wait_for_pending() - def wait_for_pending(self) -> None: with self.lock: while self.pending: -- 2.39.5