From 036ebf377278ae10b1ef470e0b4c1ccf542966e8 Mon Sep 17 00:00:00 2001 From: Wei Wang Date: Mon, 29 Jan 2024 08:26:24 +0000 Subject: [PATCH] mon: fix health store size growing infinitely The `check_mutes` wrongly marks `changed` to true, trigger `propose_pending` and block following `maybe_trim` logic (`have_pending` will be always be false); as a result, the health store will never be trimmed. Signed-off-by: Wei Wang (cherry picked from commit 05a85848a01c443d67564a9904a778acfe19cee5) --- src/mon/HealthMonitor.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mon/HealthMonitor.cc b/src/mon/HealthMonitor.cc index 6eed2b0f05bc..0c42734ef481 100644 --- a/src/mon/HealthMonitor.cc +++ b/src/mon/HealthMonitor.cc @@ -400,7 +400,7 @@ void HealthMonitor::tick() bool HealthMonitor::check_mutes() { - bool changed = true; + bool changed = false; auto now = ceph_clock_now(); health_check_map_t all; gather_all_health_checks(&all); -- 2.47.3