From 7154411d9d33eff199641c2dad6b0fe88ab9c544 Mon Sep 17 00:00:00 2001 From: John Mulligan Date: Wed, 10 Apr 2024 10:38:29 -0400 Subject: [PATCH] pybind/mgr: remove vestigial basepython directives Remove what I think are vestigial configuration parameters setting `basepython` in tox.ini. These may have been useful during the change from python 2 to 3, but I don't see them serving any useful purpose at this current time. In fact they now interfere with the ability to globally override the basepython version of all testenv's at once. So let's just remove them. We can always add it back if we find an issue in the future (and document it!). Signed-off-by: John Mulligan --- src/pybind/mgr/tox.ini | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/pybind/mgr/tox.ini b/src/pybind/mgr/tox.ini index 082d0dbd53c2..61f3643e8900 100644 --- a/src/pybind/mgr/tox.ini +++ b/src/pybind/mgr/tox.ini @@ -146,7 +146,6 @@ commands = {posargs:{[testenv:fix]modules}} [testenv:pylint] -basepython = python3 deps = pylint modules = @@ -155,7 +154,6 @@ commands = pylint {[pylint]addopts} {posargs:{[testenv:pylint]modules}} [testenv:flake8] -basepython = python3 deps = flake8 allowlist_externals = bash @@ -182,7 +180,6 @@ commands = bash -c 'test $(git ls-files cephadm | grep ".py$" | grep -v tests | xargs grep "docker.io" | wc -l) == 13' [testenv:jinjalint] -basepython = python3 deps = jinjaninja commands = -- 2.47.3