From 02bd5e1b7f4e702af391308a14a6571660c16c32 Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Fri, 24 May 2024 17:51:55 +0800 Subject: [PATCH] cmake: : link shec_utils against legacy-option-headers in c24a6ffe20, we tried to link all target dependent on legacy option headers against legacy-option-headers, but we missed some of them. in our CI, we spotted build failure like: ``` In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/erasure-code/ErasureCode.cc:26: In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/osd/osd_types.h:41: In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/common/ceph_context.h:41: In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/common/config_proxy.h:6: In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/common/config.h:27: In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/common/config_values.h:59: /home/jenkins-build/build/workspace/ceph-pull-requests/src/common/options/legacy_config_opts.h:1:10: fatal error: 'global_legacy_options.h' file not found ^~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. ``` so in this change, we link the shec_utils to `legacy-option-headers` as well to fulfill the build dependency. Signed-off-by: Kefu Chai --- src/erasure-code/shec/CMakeLists.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/erasure-code/shec/CMakeLists.txt b/src/erasure-code/shec/CMakeLists.txt index 0e699203d7c2..e7521542e311 100644 --- a/src/erasure-code/shec/CMakeLists.txt +++ b/src/erasure-code/shec/CMakeLists.txt @@ -10,6 +10,8 @@ set(shec_utils_srcs determinant.c) add_library(shec_utils OBJECT ${shec_utils_srcs}) +target_link_libraries(shec_utils + PRIVATE legacy-option-headers) set(ec_shec_objs $ -- 2.47.3