From 5dfbaac15f0ffb3dfe84ae304643d1cf4eee892d Mon Sep 17 00:00:00 2001 From: Casey Bodley Date: Tue, 9 Jul 2024 17:40:03 -0400 Subject: [PATCH] rgw/datalog: fix LazyFIFO race fix initialize `fifo_tmp` to prevent the race on member variable `fifo` that was identified in 8fa844383f9c22e758f39ecdda74f70de054ad68 Fixes: https://tracker.ceph.com/issues/66880 Signed-off-by: Casey Bodley --- src/rgw/driver/rados/rgw_log_backing.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/rgw/driver/rados/rgw_log_backing.h b/src/rgw/driver/rados/rgw_log_backing.h index 6cda9a4ca978..737d6725eb43 100644 --- a/src/rgw/driver/rados/rgw_log_backing.h +++ b/src/rgw/driver/rados/rgw_log_backing.h @@ -269,7 +269,7 @@ class LazyFIFO { // FIFO supports multiple clients by design, so it's safe to // race to create them. std::unique_ptr fifo_tmp; - auto r = rgw::cls::fifo::FIFO::create(dpp, ioctx, oid, &fifo, y); + auto r = rgw::cls::fifo::FIFO::create(dpp, ioctx, oid, &fifo_tmp, y); if (r) { return r; } -- 2.47.3